Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: idwaiter with multiple requests #1910

Merged
merged 7 commits into from
Aug 30, 2023
Merged

fix: idwaiter with multiple requests #1910

merged 7 commits into from
Aug 30, 2023

Conversation

surbhigarg92
Copy link
Contributor

@surbhigarg92 surbhigarg92 commented Aug 29, 2023 •
edited
Loading

Fixes #1908 🦕

@surbhigarg92 surbhigarg92 requested review from a team as code owners August 29, 2023 09:08
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Aug 29, 2023
@surbhigarg92 surbhigarg92 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2023
olavloite
olavloite reviewed Aug 29, 2023
View reviewed changes
src/transaction.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 29, 2023
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 30, 2023
@surbhigarg92 surbhigarg92 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
olavloite
olavloite approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/transaction.ts
@@ -101,7 +102,7 @@ export interface ReadRequest extends RequestOptions {
keys?: string[] | string[][];
ranges?: KeyRange[];
keySet?: spannerClient.spanner.v1.IKeySet | null;
limit?: number | Long | null;
limit?: number | Long | string | null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an unrelated change?

@gcf-merge-on-green gcf-merge-on-green bot merged commit 83dd1f8 into googleapis:main Aug 30, 2023
14 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
@release-please release-please bot mentioned this pull request Aug 30, 2023
Merged
@surbhigarg92 surbhigarg92 deleted the issue_1908 branch August 30, 2023 09:07
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 30, 2023
@release-please
chore(main): release 7.0.0 (#1900)
65f6a83 
🤖 I have created a release *beep* *boop*
---


## [7.0.0](https://togithub.com/googleapis/nodejs-spanner/compare/v6.16.0...v7.0.0) (2023-08-30)


### ⚠ BREAKING CHANGES

* upgrade to Node 14 ([#1890](https://togithub.com/googleapis/nodejs-spanner/issues/1890))

### Bug Fixes

* Idwaiter with multiple requests ([#1910](https://togithub.com/googleapis/nodejs-spanner/issues/1910)) ([83dd1f8](https://togithub.com/googleapis/nodejs-spanner/commit/83dd1f8201d07898bd3ddff9e339dfbcef7d7ace))


### Miscellaneous Chores

* Upgrade to Node 14 ([#1890](https://togithub.com/googleapis/nodejs-spanner/issues/1890)) ([0024772](https://togithub.com/googleapis/nodejs-spanner/commit/0024772b750de404cd44771e320fe89cd430f064))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction Promise.all with multiple queries results in Error: stream.push() after EOF
3 participants
@surbhigarg92 @olavloite @yoshi-kokoro